We will look at this argument and see which part holds validity. I want people to understand that I am not writing this for people to start debates or throw it into people's faces. Rather, as I have said before I want to bring some clarity on its stance in faith and whether there is an affect on faith or not.
One cannot leave faith unless he negates that which brought him into faith, i.e. the testification of faith.
The word daa means call like you would call someone and root Arabic word دعا which means to call or summon. (Hans wher p.282) So the basis of the disagreement is that people are calling to other than Allah (the Exalted). Yet, most of the dictionary definitions are not about calling an idol. If you read, the passage and you will realise that the accusation is not justified.
Kufr and Shirk cannot be declared except when matters are clear and not basing it on incorrect analogies. It has to clear without any room for doubt which is not the case in this accusation. Neither can these ayahs be used as proof.
Ya Rasul Allah in Hadith
These are five examples in which the Prophet (may Allah bestow peace and blessings upon him) heard a companion ask a question and did not respond by saying that Ya Rasul Allah means shirk. Rather he (may Allah bestow peace and blessings upon him) just answered the question. For the sake of brevity, there are twenty five such examples at the end of this article.
Attached are pictures from the hadith compilation called Miskat Al-Masabih. In the index, I found something that shocked me further. There are over 115 hadith with the companions saying Ya Rasul Allah, 10 with Ya Muhammad and 6 with Ya Nabi Allah. Please see attached pictures.